-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second comment block #6
Comments
+1 |
Looks like it comes from typedoc: https://github.com/TypeStrong/typedoc/blob/master/src/lib/converter/factories/comment.ts#L91-L93. |
If you think it would work, I will def merge it!
…On Tue, Mar 28, 2017 at 4:55 AM Filips Alpe ***@***.***> wrote:
Looks like it comes from typedoc:
https://github.com/TypeStrong/typedoc/blob/master/src/lib/converter/factories/comment.ts#L91-L93
.
No idea why they're doing this but one of the options is reimplementing
getRawComment in this repo. @christopherthielen
<https://github.com/christopherthielen> I'd be happy to submit a PR if
you think this would be the proper solution.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB9VZvVJRQvOvtkCoX5me2aPTXyOoqhIks5rqNkYgaJpZM4L1Bur>
.
|
I considered submitting a PR to typedoc instead, however, it seems that they're intentionally doing this to avoid including stuff like license headers in the docs. PR coming up soon. |
Adapt `getRawComment` from `typedoc` to prevent skipping over the topmost jsdoc block if only one such block is present. Closes christopherthielen#6
Adapt `getRawComment` from `typedoc` to prevent skipping over the topmost jsdoc block if only one such block is present. Closes christopherthielen#6
…quiring a second comment block. Closes #6
I'm still seeing this issue. |
@adrice727 can you post your repo? I'd like to take a look |
@christopherthielen It's currently private, but it should be public in another week or so. |
Released 1.1.1 which should correctly address this now. Sorry for the delay |
From the readme,
A known issue: The comment block must be followed by another comment block for some reason (?)
Is this a typedoc issue or an issue with this plugin? Is there any info on any progress being made to solve it?
Thanks 😄
The text was updated successfully, but these errors were encountered: