Fixes for GTK3 builds in Wayland sessions #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yselkowitz
commented
Dec 23, 2021
yselkowitz
commented
- Force X11 if built without AppIndicator
- Fix issues when running on GTK3 with Wayland
When built without AppIndicator, this is by definition an X11 tray icon. When built with GTK3 (which is usually built to support both Wayland and X11), and run on a Wayland desktop, X11/XWayland is the only viable option for this program, and needs to be forced to start properly.
Because GTK3 supports multiple backends, any backend-specific code (such as X11 key grabbing or property interaction) needs to be conditionalized at runtime. Otherwise, when built with AppIndicator support and run on a Wayland desktop, the attempted X11 calls will cause this to crash.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.