fix useStripeCustomerFetch nonNilAssertion error

chrisvdm · Jul 16, 2024 · c8b47a6 · c8b47a6
1 parent 83df11d
commit c8b47a6
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/web/src/hooks/useStripeCustomerFetch.ts b/web/src/hooks/useStripeCustomerFetch.ts
@@ -10,6 +10,7 @@ import type {
 } from "../generated/graphql.js";
 import { nonNilAssertionError } from "../lib/nonNilAssertionError.js";
 import type { StripeCustomerBase } from "../types.js";
+import { isEmptyString } from "../lib/index.js"
 
 const STRIPE_CUSTOMER_SEARCH = gql`
     query stripeCustomerSearch(
@@ -116,13 +117,15 @@ export const useStripeCustomerFetch = (
   setCustomer: (customer: StripeCustomerBase) => unknown,
 ) => {
   const client = useApolloClient();
+
   useEffect(() => {
     const doFetch = async () => {
       const context = {
         id,
         client,
         searchString,
       };
+
       const stripeCustomer = await fetchCustomer(context);
 
       if (stripeCustomer == null) {
@@ -135,6 +138,11 @@ export const useStripeCustomerFetch = (
       setCustomer(stripeCustomer);
     };
 
-    doFetch();
+    if(!isEmptyString(id) || !isEmptyString(searchString)) {
+      doFetch();
+    }
+
+
   }, [searchString, id]);
 };
+
diff --git a/web/src/lib/index.ts b/web/src/lib/index.ts
@@ -1,2 +1,3 @@
 export * from "./logger.js";
 export * from "./isEmptyObj.js";
+export * from "./isEmptyString.js"
diff --git a/web/src/lib/isEmptyString.ts b/web/src/lib/isEmptyString.ts
@@ -0,0 +1,3 @@
+export const isEmptyString = (value: unknown) => {
+    return (value == null || (typeof value === "string" && value.trim().length === 0));
+}