Skip to content

Commit

Permalink
[ENH] Metadata segment GRPC reader (#2041)
Browse files Browse the repository at this point in the history
## Description of changes

*Summarize the changes made by this PR.*
 - New functionality
- Metadata segment reader proto types and python implementation.
Rust-side server implementation coming in my next PR.

## Test plan
*How are these changes tested?*

- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
*Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
repository](https://github.com/chroma-core/docs)?*
  • Loading branch information
beggers authored Apr 24, 2024
1 parent e915b21 commit df65e5a
Show file tree
Hide file tree
Showing 14 changed files with 1,377 additions and 227 deletions.
2 changes: 1 addition & 1 deletion chromadb/api/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ def validate_where(where: Where) -> Where:
or not all(isinstance(x, type(operand[0])) for x in operand)
):
raise ValueError(
f"Expected where operand value to be a non-empty list, and all values to obe of the same type "
f"Expected where operand value to be a non-empty list, and all values to be of the same type "
f"got {operand}"
)
return where
Expand Down
101 changes: 72 additions & 29 deletions chromadb/proto/chroma_pb2.py

Large diffs are not rendered by default.

255 changes: 217 additions & 38 deletions chromadb/proto/chroma_pb2.pyi

Large diffs are not rendered by default.

67 changes: 67 additions & 0 deletions chromadb/proto/chroma_pb2_grpc.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

71 changes: 36 additions & 35 deletions chromadb/proto/coordinator_pb2.py

Large diffs are not rendered by default.

74 changes: 39 additions & 35 deletions chromadb/proto/coordinator_pb2.pyi

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit df65e5a

Please sign in to comment.