Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLN] Cleaned up OpenAI JS EF #2108

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[CLN] Cleaned up OpenAI JS EF #2108

wants to merge 11 commits into from

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented May 1, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Removed unnecessary complex way of importing openai lib
    • Added extra error handling for checking for older version <3
  • New functionality
    • Added support for org Id in v4 client

Test plan

How are these changes tested?

  • Tests pass locally with yarn test for js

Documentation Changes

N/A

@vercel Vercel
Copy link

vercel bot commented May 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 11:38am

@tazarov Graphite App
Copy link
Contributor Author

tazarov commented May 1, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

AlabasterAxe
AlabasterAxe approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@AlabasterAxe AlabasterAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a little pedantic on this PR so feel free to ignore me if it doesn't resonate with you :)

I do think it might be nice to resolve the potential double initialization issue but also up to you!

clients/js/src/embeddings/OpenAIEmbeddingFunction.ts Outdated Show resolved Hide resolved
clients/js/src/embeddings/OpenAIEmbeddingFunction.ts Outdated Show resolved Hide resolved
clients/js/src/embeddings/OpenAIEmbeddingFunction.ts Outdated Show resolved Hide resolved
clients/js/src/embeddings/OpenAIEmbeddingFunction.ts Outdated Show resolved Hide resolved
@tazarov tazarov requested a review from AlabasterAxe May 9, 2024 12:34
AlabasterAxe
AlabasterAxe approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@AlabasterAxe AlabasterAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

clients/js/src/embeddings/OpenAIEmbeddingFunction.ts Outdated Show resolved Hide resolved
@tazarov tazarov force-pushed the trayan-05-01-fix_cleaned_up_openai_ef_js_function branch from 3c81a6e to 52602e2 Compare May 10, 2024 06:14
@tazarov tazarov force-pushed the trayan-05-01-fix_cleaned_up_openai_ef_js_function branch from 7cd4d96 to 52602e2 Compare May 10, 2024 06:37
@tazarov
Copy link
Contributor Author

tazarov commented May 10, 2024

@AlabasterAxe, I think we should bite the bullet on the Lint CI and it seems to be a rabbit hole (I'll fix in another PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlabasterAxe AlabasterAxe AlabasterAxe approved these changes

@jeffchuber jeffchuber Awaiting requested review from jeffchuber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tazarov @AlabasterAxe