Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variables #102

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Rename variables #102

merged 6 commits into from
Sep 15, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Sep 15, 2023

As discussed:

  • storyBuild -> selectedBuild
  • nextBuild -> lastBuildOnBranch
  • runningBuild -> localBuilldProgress

I also renamed the stories to (hopefully be more understandable). @MichaelArestad you might want to take an opportunity to review those stories.

You can see there were no changes[1] before I did that:
image

[1] Actually there were two changes I accepted on that build just because I was messing around with local builds with Zol.

📦 Published PR as canary version: 0.0.75--canary.102.37592de.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.75--canary.102.37592de.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.75--canary.102.37592de.0

Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

src/components/SidebarTopButton.tsx Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
@ghengeveld ghengeveld merged commit d98e6b0 into main Sep 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants