Clear access token on expiration or auth error #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no viewer data from API
AP-3631 Log user out when API token expires
Let's do the equivalent of AP-3255 in the VT addon. We can address AP-3254 later. |
tmeasday
reviewed
Sep 16, 2023
@tmeasday I just manually messed up (edited) my JWT in localStorage to make it invalid. |
|
Nice! |
ghengeveld
force-pushed
the
ghengeveld/ap-3631-log-user-out-when-api-token-expires
branch
3 times, most recently
from
c6177ba
to
1f9f4b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears the access token from memory and localStorage when either the token expires or the API returns either an auth error or no
viewerdata.I've updated our setup to use URQL's
authExchangerather than our own custom header injection. This makes it a little more "intelligent" about not sending a request if we already know it will fail. It also is able to automatically retry a request after refreshing the token (e.g. using a refreshToken) but we don't have that capability yet.📦 Published PR as canary version:
0.0.88--canary.105.7ed4611.0✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.88--canary.105.7ed4611.0 # or yarn add @chromaui/addon-visual-tests@0.0.88--canary.105.7ed4611.0