Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement horizontal panel layout #109

Merged

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Sep 17, 2023

📦 Published PR as canary version: 0.0.83--canary.109.797ede2.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.83--canary.109.797ede2.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.83--canary.109.797ede2.0

@linear
Copy link

linear bot commented Sep 17, 2023

@ghengeveld ghengeveld marked this pull request as ready for review September 18, 2023 20:20
Copy link
Contributor

@MichaelArestad MichaelArestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for making this change!

.storybook/preview.tsx Show resolved Hide resolved
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a decent refactoring but I don't see stories for wider viewports so I'm not sure if it actually works?

@ghengeveld
Copy link
Member Author

ghengeveld commented Sep 19, 2023

@tmeasday I'm going to setup multi-mode snapshots in a separate PR (I tried in this one but it's more work than I'd hoped). So for now it requires manually switching to the bottom (stacked) theme.

@ghengeveld ghengeveld merged commit 832ea56 into main Sep 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants