-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement horizontal panel layout #109
Implement horizontal panel layout #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks for making this change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a decent refactoring but I don't see stories for wider viewports so I'm not sure if it actually works?
@tmeasday I'm going to setup multi-mode snapshots in a separate PR (I tried in this one but it's more work than I'd hoped). So for now it requires manually switching to the |
📦 Published PR as canary version:
0.0.83--canary.109.797ede2.0
✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.83--canary.109.797ede2.0 # or yarn add @chromaui/addon-visual-tests@0.0.83--canary.109.797ede2.0