Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup TurboSnap #115

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Setup TurboSnap #115

merged 3 commits into from
Sep 22, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Sep 20, 2023

📦 Published PR as canary version: 0.0.93--canary.115.a91e3de.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.93--canary.115.a91e3de.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.93--canary.115.a91e3de.0

@ghengeveld ghengeveld marked this pull request as draft September 20, 2023 09:59
@ghengeveld ghengeveld marked this pull request as ready for review September 20, 2023 10:48
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not put the settings in x.config.json and have it apply to the addon too?

@ghengeveld
Copy link
Member Author

Why not put the settings in x.config.json and have it apply to the addon too?

@tmeasday What do you mean exactly? I can put onlyChanged and externals in production.config.json but it wouldn't work because the Action doesn't support the config file (at least it doesn't support the configFile option, maybe it does pick up the default?).

You seem to suggest adding TurboSnap support to the addon itself too (so builds run through the addon can use TS)? That seems like a bigger project than what I'm trying to achieve here (speed up our CI builds).

@tmeasday
Copy link
Member

Builds through the addon will use turbo snap if it's configured in the config.json. I turned it on for the SB and CH monorepo and and haven't seen any issues yet.

I guess I neglected to add support for the configFile option in the action, we should add that.

@ghengeveld ghengeveld merged commit c982f99 into main Sep 22, 2023
6 checks passed
@ghengeveld ghengeveld deleted the setup-turbosnap branch September 22, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants