Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the filter when removing the sidebar toggle button #120

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Sep 22, 2023

It was possible to filter the sidebar, then change branch (or run another build) so that the button disappears but the filter remains active (so you can no longer clear it!). This change means that the filter will reset whenever the filter goes away (whenever the story book state has no warnings).

In theory there might be situations where this happens for a brief moment, but it doesn't seem to happen in my testing.

To QA

  1. Pick a branch where the latest build has changes (or make one)
  2. Turn on the filter
  3. Switch to a branch where there are no changes on the latest build (e.g. main).
  4. The filter should turn off and all stories should be visible.

@linear
Copy link

linear bot commented Sep 22, 2023

AP-3683 Possible to filter out all stories with no way to disable

  1. Run a build with changes
  2. Turn on filter
  3. Run a new build without changes

You'll see (no stories, but note no button to disable the filter):

image.png

@tmeasday tmeasday merged commit 3481f8c into main Sep 22, 2023
3 checks passed
@tmeasday tmeasday deleted the tom/ap-3683-possible-to-filter-out-all-stories-with-no-way-to-disable branch September 22, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants