New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @storybook/icons from externals #174

Merged

thafryer merged 1 commit into main from jarel/ap-4200-visual-testing-addon-error-with-latest-stable-storybook

Feb 6, 2024

Member

thafryer commented Feb 6, 2024 •

edited

Loading

This removes @storybook/icons from externals so that the addon successfully runs in SB 7.6

To QA:
Canary: @chromatic-com/storybook@1.1.1--canary.8181fc2.0

Install the Canary in a 7.6 project and confirm that a build can be run.


          Remove @storybook/icons from externals

8181fc2

thafryer added release patch labels

thafryer requested review from shilman, ndelangen and jonniebigodes

February 6, 2024 13:22

JReinhold approved these changes

View reviewed changes

thafryer merged commit 150e995 into main

6 checks passed

thafryer deleted the jarel/ap-4200-visual-testing-addon-error-with-latest-stable-storybook branch

February 6, 2024 16:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels