Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kebab-case box-shadow to proper boxShadow #181

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Feb 7, 2024

There's currently an error in the console of any Storybook with VTA about using box-shadow while only boxShadow is allowed:

image

The kebab-cased style won't be applied so the warning is valid.

This was probably an oversight during the hectic transformation of CSS styles to JS object styles at 76466a5#diff-6670cf4c6d5074d9ed37d761697fbbc372e5aa961f0907c7b305a1bd7f1e0e2aR118

@JReinhold JReinhold changed the title Fix hoverEffect box-shadow to proper boxShadow Fix kebab-case box-shadow to proper boxShadow Feb 7, 2024
@JReinhold JReinhold marked this pull request as ready for review February 7, 2024 22:50
Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JReinhold
Copy link
Contributor Author

JReinhold commented Feb 7, 2024

I just noticed that the hoverEffect is not used anywhere, so it could also be valid to remove the whole object completely. Up to you.

@JReinhold JReinhold added bug Classification: Something isn't working release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Feb 8, 2024
@JReinhold JReinhold merged commit 5a566fe into main Feb 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants