Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only throw errors for Git messages after a Project ID has been set #186

Conversation

thafryer
Copy link
Member

@thafryer thafryer commented Feb 12, 2024

The Git Errors are currently shown to the user before they have had a chance to configure a project ID for running builds. This ens

To QA:

  1. Install this canary.
  2. Ensure the git message does not show before a project ID is configured.
  3. Ensure the git message shows after the project ID is configured.
  4. Ensure it goes away after initializing git and making a few commits!
📦 Published PR as canary version: 1.1.7--canary.186.1f27e41.0

✨ Test out this PR locally via:

npm install @chromatic-com/storybook@1.1.7--canary.186.1f27e41.0
# or 
yarn add @chromatic-com/storybook@1.1.7--canary.186.1f27e41.0

@thafryer thafryer force-pushed the jarel/ap-4239-chromatic-addon-fails-when-initializing-storybook-on-an branch 5 times, most recently from beb9544 to 66efca2 Compare February 12, 2024 16:38
@thafryer thafryer force-pushed the jarel/ap-4239-chromatic-addon-fails-when-initializing-storybook-on-an branch from 66efca2 to 1f27e41 Compare February 12, 2024 16:49
Copy link
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and QA'd well 👍🏻

@thafryer thafryer merged commit d888b16 into main Feb 13, 2024
6 checks passed
@thafryer thafryer deleted the jarel/ap-4239-chromatic-addon-fails-when-initializing-storybook-on-an branch February 13, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants