Reset Diff Toggles for New Stories #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thafryer
force-pushed
the
jarel/ap-4098-bug-toggling-between-changed-and-added-stories-with-baseline
branch
2 times, most recently
from
6bf4eed
to
ea86b92
Compare
tmeasday
reviewed
Feb 16, 2024
tmeasday
approved these changes
Feb 16, 2024
ghengeveld
reviewed
Feb 16, 2024
andrewortwein
approved these changes
Feb 20, 2024
thafryer
force-pushed
the
jarel/ap-4098-bug-toggling-between-changed-and-added-stories-with-baseline
branch
from
ea86b92
to
ef8d100
Compare
thafryer
force-pushed
the
jarel/ap-4098-bug-toggling-between-changed-and-added-stories-with-baseline
branch
from
6a53faf
to
b9d9130
Compare
thafryer
force-pushed
the
jarel/ap-4098-bug-toggling-between-changed-and-added-stories-with-baseline
branch
from
b990c64
to
a1de870
Compare
thafryer
deleted the
jarel/ap-4098-bug-toggling-between-changed-and-added-stories-with-baseline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you changed to a story where the comparison is new and the Baseline toggle shows the baseline snapshot, there would be no image shown in the comparison viewer. This PR adjusts the behavior so that for new stories, the user always sees the latest snapshot.
To QA:
📦 Published PR as canary version:
1.1.10--canary.187.a1de870.0✨ Test out this PR locally via:
npm install @chromatic-com/storybook@1.1.10--canary.187.a1de870.0 # or yarn add @chromatic-com/storybook@1.1.10--canary.187.a1de870.0