Show error when build is limited (account is out of snapshots) #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of-builds-for-the-month-local-build
thafryer
approved these changes
Mar 5, 2024
|
@MichaelArestad did you have an error state for this? |
|
Code changes look fine to me, but should we try to implement the error state designs above? |
|
I think we should try to implement the error state because it associates the blocker with "upgrading plan". |
…of-builds-for-the-month-local-build
…r when account is out of snapshots
ghengeveld
deleted the
ghengeveld/ap-4102-bug-when-a-user-runs-out-of-builds-for-the-month-local-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than hanging the build at the Verify step, fail the build with an error and link to the Billing screen.
I did not bother designing this to be any fancier than the default error message we already had.
📦 Published PR as canary version:
1.2.8--canary.194.78d37d8.0✨ Test out this PR locally via:
npm install @chromatic-com/storybook@1.2.8--canary.194.78d37d8.0 # or yarn add @chromatic-com/storybook@1.2.8--canary.194.78d37d8.0