Onboarding UI AP-3252 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeksling
approved these changes
Jun 8, 2023
src/utils/useSignIn.ts
Outdated
| // @ts-expect-error File is in plain JS | ||
| import { sha256 } from "./sha256"; | ||
|
|
||
| const CHROMATIC_BASE_URL = "https://www.staging-chromatic.com"; |
There was a problem hiding this comment.
This will need to be configurable or to be updated to https://www.chromatic.com
I set it to the review app for testing purposes. Not sure how other addons deal with this sort of thing, but figma-addon has uses an environment variable:
const apiUrl = process.env.STORYBOOK_CHROMATIC_API_URL || "https://www.chromatic.com";
There was a problem hiding this comment.
Yep this was on my TODO list. At some point I got a "process is not defined" error but maybe that was a red herring.
Co-authored-by: Matthew Weeks <matt@chromatic.com>
…ests into onboarding-ui
AP-3252 Authentication with Chromatic
This is an umbrella issue for lifting the authentication mechanism from the Figma addon into the Chromatic addon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This scaffolds the onboarding UI. No functionality yet.
📦 Published PR as canary version:
0.0.3--canary.2.fc8a4d0.0✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.3--canary.2.fc8a4d0.0 # or yarn add @chromaui/addon-visual-tests@0.0.3--canary.2.fc8a4d0.0