Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show screen when there's no dev server #205

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Show screen when there's no dev server #205

merged 2 commits into from
Mar 8, 2024

Conversation

thafryer
Copy link
Member

@thafryer thafryer commented Mar 8, 2024

To QA:

  1. Run storybook build.
  2. Serve the storybook using npx serve.
  3. Confirm that you cannot do any Visual Tests Addon functionality.
📦 Published PR as canary version: 1.2.11--canary.205.d4d987c.0

✨ Test out this PR locally via:

npm install @chromatic-com/storybook@1.2.11--canary.205.d4d987c.0
# or 
yarn add @chromatic-com/storybook@1.2.11--canary.205.d4d987c.0

Copy link
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙅👍🏻

@andrewortwein
Copy link
Contributor

QA passes!

@thafryer thafryer merged commit 1c4cdd9 into main Mar 8, 2024
6 checks passed
@thafryer thafryer deleted the no-dev-server branch March 8, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants