Send a sessionId on graphql requests #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeksling
reviewed
Aug 11, 2023
weeksling
approved these changes
Aug 11, 2023
|
Oh, hey I noticed something odd here... I accepted my own local build on another branch for the no build story, and it seems like it's now being applied as the baseline for merging to main... Is that expected? |
@weeksling it looks like you accepted it on this branch: https://www.chromatic.com/test?appId=6480e1b0042842f149cfd74c&id=64d6994da701c906f8bc611b -- I reached out on slack to try and nail down what happened exactly. I won't merge this until we figure it out just for record keeping (I think this PR is good to merge though, apart from possible messed up baselines) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can track sessions in the index (PR to follow). The CLI already sends a
sessionIdin a very similar way: https://github.com/chromaui/chromatic-cli/blob/cfb2f280a92b5a01532ca625b0b55b180d8de37b/node-src/index.ts#L48📦 Published PR as canary version:
0.0.24--canary.22.6913426.0✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.24--canary.22.6913426.0 # or yarn add @chromaui/addon-visual-tests@0.0.24--canary.22.6913426.0