Fix bug that hid the last project in the list #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AP-3443 Project picker improvements
|
weeksling
changed the title
tmeasday
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
LGTM in the storybook!
@weeksling did you look at scrolling the story in a play function? Not a big deal but a good idea if easy
|
@tmeasday added the play function to the story. It was easier than I thought |
…lex to make list height match the container, not 1 list item longer
weeksling
force-pushed
the
matt/ap-3443-project-picker-improvements
branch
from
c29f6cb
to
c12e168
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/chromaui/issue/AP-3443/project-picker-improvements
This fixes the major UI bug that prevented the last project in a long list being displayed correctly. Automatically selected the first account to make project selection easier.
Second bullet will be split into a separate pr as it requires a change to the public API to support orderBy parameters in the queries for viewers.accounts and viewers.accounts.projects
📦 Published PR as canary version:
0.0.30--canary.27.91e4436.0✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.30--canary.27.91e4436.0 # or yarn add @chromaui/addon-visual-tests@0.0.30--canary.27.91e4436.0