Open addon panel when notification is clicked, and pass new duration option
#281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pen panel when clicked
…-so-that-it-can-sho
ndelangen
approved these changes
Apr 4, 2024
ghengeveld
deleted the
ghengeveld/264-make-notification-interactive-so-that-it-can-sho
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264
This uses the new
durationandonClickoptions foraddNotification.Most notifications will auto-close after 8 seconds. The original timeout mechanism is kept in place for backwards compatibility.
When a notification is clicked, the notification is dismissed and the VTA panel is opened/made visible.
To QA, run
npx storybook@0.0.0-pr-26696-sha-63254fdd upgradeto get access to the updated notification API.📦 Published PR as canary version:
1.3.0--canary.281.6e67049.0✨ Test out this PR locally via:
npm install @chromatic-com/storybook@1.3.0--canary.281.6e67049.0 # or yarn add @chromatic-com/storybook@1.3.0--canary.281.6e67049.0