Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add footer menu to link project screen #29

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Add footer menu to link project screen #29

merged 1 commit into from
Aug 14, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Aug 9, 2023

Fixes AP-3494

This allows one to sign out from the link step.

Screenshot 2023-08-09 at 15 38 36
📦 Published PR as canary version: 0.0.18--canary.29.00fa44b.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.18--canary.29.00fa44b.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.18--canary.29.00fa44b.0

@linear
Copy link

linear bot commented Aug 9, 2023

AP-3494 Allow signing out while on the linking step

We need to show the footer menu on the "link project" step so that it's possible to sign out of Chromatic from this step. Otherwise there is no way to sign out without manually clearing localStorage, in case you accidentally signed in to the wrong account.

Copy link
Contributor

@weeksling weeksling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghengeveld ghengeveld merged commit 3e82519 into main Aug 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants