Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade some deprecated uses of @storybook/components #316

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented May 28, 2024

📦 Published PR as canary version: 1.5.1--canary.316.abf1bd4.0

✨ Test out this PR locally via:

npm install @chromatic-com/storybook@1.5.1--canary.316.abf1bd4.0
# or 
yarn add @chromatic-com/storybook@1.5.1--canary.316.abf1bd4.0

@ghengeveld ghengeveld requested a review from thafryer May 31, 2024 12:19
Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that I get the connection between the title and PR changes. Yet, if this is meant to just clean up various improper usage of icons, this makes sense.

@ghengeveld
Copy link
Member Author

@thafryer Yeah sorry this was also supposed to replace deprecated Button props. I've added that now.

@ghengeveld ghengeveld added skip-release Auto: Preserve the current version when merged patch Auto: Increment the patch version when merged labels Jun 3, 2024
@ghengeveld ghengeveld merged commit ba7fa33 into main Jun 5, 2024
9 of 10 checks passed
@ghengeveld ghengeveld deleted the update-deprecated-components branch June 5, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants