Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use modern Yarn and run on port 6004 #325

Merged
merged 6 commits into from
Jun 27, 2024
Merged

Use modern Yarn and run on port 6004 #325

merged 6 commits into from
Jun 27, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Jun 25, 2024 •
edited
Loading

Make sure we use Yarn Berry rather than some ancient version.
Also, run Storybook on port 6004 to avoid port conflicts.

@ghengeveld ghengeveld changed the title Use modern Yarn Use modern Yarn and run on port 6004 Jun 25, 2024
@ghengeveld ghengeveld added skip-release Auto: Preserve the current version when merged patch Auto: Increment the patch version when merged labels Jun 25, 2024
andrewortwein
andrewortwein requested changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a packageManager field to package.json? When I run an install, corepack keeps prompting me that one isn't there and that it will add it.

andrewortwein
andrewortwein approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧶4️⃣👍🏻

@ghengeveld ghengeveld merged commit 3465e9d into main Jun 27, 2024
8 checks passed
@ghengeveld ghengeveld deleted the use-yarn-berry branch June 27, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewortwein andrewortwein andrewortwein approved these changes

@valentinpalkovic valentinpalkovic Awaiting requested review from valentinpalkovic

Assignees
No one assigned
Labels
patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghengeveld @andrewortwein