Relay client-side fetch requests to the server using the Storybook channel API #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and have URQL use it
ndelangen
reviewed
Jul 16, 2024
ndelangen
reviewed
Jul 16, 2024
ndelangen
reviewed
Jul 16, 2024
ndelangen
reviewed
Jul 16, 2024
ghengeveld
force-pushed
the
312-api-channel-proxy
branch
from
44029cc
to
2f1d25b
Compare
ndelangen
approved these changes
Jul 25, 2024
ghengeveld
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312
This adds a
ChannelFetchutility anduseChannelFetchhook. ChannelFetch listens for messages on theserverChannel, performsfetchrequests, and sends back a message with the response. The goal is relay client-side requests to the server, in order to avoid polluting the network request log in DevTools.A
useChannelFetchhook is included, which returns afetchcompatible function. Thisfetchreplacement is passed to the URQL Client so all GraphQL requests will happen over the channel. Requests time out after 30 seconds (if they haven't already). Thesignalproperty is supported by means of a dedicated abort message.📦 Published PR as canary version:
1.9.0--canary.331.67b13f2.0✨ Test out this PR locally via:
npm install @chromatic-com/storybook@1.9.0--canary.331.67b13f2.0 # or yarn add @chromatic-com/storybook@1.9.0--canary.331.67b13f2.0