Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent running tests from Testing Module while there's a warning #345

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Prevent running tests from Testing Module while there's a warning #345

merged 1 commit into from
Oct 30, 2024

Conversation

ghengeveld
Copy link
Member

Sets runnable: false while there is a warning, in order to prevent tests from running while not logged in (among other warnings):

Screenshot 2024-10-30 at 11 10 59

@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Oct 30, 2024
@ghengeveld ghengeveld merged commit 1bd27fd into main Oct 30, 2024
10 checks passed
@ghengeveld ghengeveld deleted the disable-runnable-on-warning branch October 30, 2024 10:20
@ghengeveld
Copy link
Member Author

🚀 PR was released in v3.2.1 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

@valentinpalkovic valentinpalkovic Awaiting requested review from valentinpalkovic

Assignees
No one assigned
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghengeveld @yannbf