Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade storybook & make development easier #62

Merged
merged 1 commit into from
Aug 30, 2023
Merged

upgrade storybook & make development easier #62

merged 1 commit into from
Aug 30, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Aug 30, 2023

I made a change so there's no need to build the addon before starting storybook anymore.

If you want to use the dist anyway (for example to test check bundle-size or perf) you can prepend this to your start command:

CHROMATIC_USE_DIST_VERSION=true

This will only work locally, as this switch is implemented in the main.ts of the local storybook in this repo.

Addon users will always use the dist version.

@ndelangen ndelangen self-assigned this Aug 30, 2023
@ndelangen ndelangen added the enhancement Classification: Improvement to existing feature label Aug 30, 2023
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@tmeasday tmeasday merged commit 23a0f27 into main Aug 30, 2023
3 checks passed
@tmeasday tmeasday deleted the norbert/dev branch August 30, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Classification: Improvement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants