Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR that includes both #64 and #56 #68

Merged
merged 10 commits into from
Sep 4, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Sep 1, 2023

Placeholder for a merge base, DO NOT MERGE

📦 Published PR as canary version: 0.0.51--canary.68.4da4ede.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.51--canary.68.4da4ede.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.51--canary.68.4da4ede.0

@linear
Copy link

linear bot commented Sep 1, 2023

AP-3544 Implement "build of out date" behaviour

As discussed in Slack: https://chromaticqa.slack.com/archives/C051TQR6QLC/p1692354384352659

  1. When a new (local) build is running, show a eyebrow UI for the progress (AP-3559)
  2. When it is complete, continue to show the old build, but prompt the user to switch
  3. When they switch or change stories, show the new build from now on.
  4. When you change branch/commit, if there is a newer CI build available, behaviour similarly as to 2&3
  5. Alert users when there is a new build available on a newer commit on the current branch.

Some details still being thrashed out. The details of the eyebrow and 5. are probably large enough to deserve their own tickets.

Discussion here: https://www.notion.so/chromatic-ui/Persisting-information-in-the-addon-20f4b982692b40d09e4211635581e62b?pvs=4

@tmeasday tmeasday merged commit 4da4ede into main Sep 4, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant