-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AP 3560] Build UI for build status #76
Conversation
…ests into matt/ap-3560-ext-build-ui-for-build-status
…ot implemented - no history
cdb6e93
to
8e1d95c
Compare
8e1d95c
to
7cd0334
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. A lot of smaller feedback. Probably my biggest concern is the "history" being storied in a leaf component's state, that seems fragile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, test seems like the right approach!
This builds out most of the ui for the progress bar and build status, extending #56
Note this is not complete.
📦 Published PR as canary version:
0.0.68--canary.76.d059219.0
✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.68--canary.76.d059219.0 # or yarn add @chromaui/addon-visual-tests@0.0.68--canary.76.d059219.0