Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Render the panel in JSX (but hidden) when inactive #78

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

ndelangen
Copy link
Member

What I did

  • I added a prop hidden to the container component used for the Panel.
  • A wrapped the content in another one of those wrappers, because that seemed like the easiest way to get this done quick. I didn't want to make changes all over the place at this time.

I could remove the double container, but I'd have to touch something like 10 components and possibly a similar number of story files (add decorators if needed).
I opted not to do that right now.

How to test

  • open storybook in the repo
  • open the actions panel
  • refresh the page
  • the visual tests addon panel should not be shown
  • assert that state does get set (easy way to verify is to look at the network tab)

@ndelangen ndelangen self-assigned this Sep 6, 2023
@ndelangen ndelangen added the enhancement Classification: Improvement to existing feature label Sep 6, 2023
@ndelangen ndelangen merged commit a4c8e43 into main Sep 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Classification: Improvement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants