Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a compose @storybook/components in our Storybook #88

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Sep 8, 2023

@ndelangen this isn't working for me. Any idea why?

image image
📦 Published PR as canary version: 0.0.65--canary.88.12cd3d6.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.65--canary.88.12cd3d6.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.65--canary.88.12cd3d6.0

@tmeasday tmeasday marked this pull request as draft September 8, 2023 00:16
@tmeasday tmeasday changed the title Add a ref to components Add a compose @storybook/components in our Storybook Sep 10, 2023
@ndelangen
Copy link
Member

I'll investigate!

@ndelangen
Copy link
Member

ndelangen commented Sep 11, 2023

Chromatic is returning non-json because storybook isn't requesting the proper URL:

https://next--635781f3500dd2c49e189caf.chromatic.com/?path=/story/blocks-blocks-anchor--default/index.json

Screenshot 2023-09-11 at 11 51 01
Screenshot 2023-09-11 at 11 50 54

AHHH I found it... your URL does contain the query!

@ndelangen
Copy link
Member

I'm pushing a fix

@tmeasday
Copy link
Member Author

🤦

@ndelangen ndelangen marked this pull request as ready for review September 12, 2023 12:10
@ndelangen ndelangen merged commit 0addfcb into main Sep 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants