generated from storybookjs/addon-kit
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep the "create first build" UI right up until the running build has captured this story #89
Merged
tmeasday
merged 9 commits into
main
from
tom/ap-3645-dont-switch-to-first-build-until-it-has-completed
Sep 15, 2023
Merged
Keep the "create first build" UI right up until the running build has captured this story #89
tmeasday
merged 9 commits into
main
from
tom/ap-3645-dont-switch-to-first-build-until-it-has-completed
Sep 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AP-3645 Don't switch to first build until it has completed
As discussed with m we'll keep the "run your first build" with a progress bar until it finishes |
tmeasday
changed the base branch from
tom/ap-3633-show-snapshot-outdated-header-as-soon-as-we-have-a-new
to
main
September 12, 2023 05:08
tmeasday
force-pushed
the
tom/ap-3645-dont-switch-to-first-build-until-it-has-completed
branch
from
September 12, 2023 05:14
98ed42b
to
2fac687
Compare
@tmeasday Let's make a separate ticket. I don't want to extend the scope of what I'm working on right now. |
ghengeveld
approved these changes
Sep 12, 2023
TODO after discussion with @MichaelArestad:
|
Going to need to resolve this with your stuff @ghengeveld so I will hold off merging. |
tmeasday
force-pushed
the
tom/ap-3645-dont-switch-to-first-build-until-it-has-completed
branch
from
September 14, 2023 11:30
9233087
to
be34a5c
Compare
…ch-to-first-build-until-it-has-completed
tmeasday
deleted the
tom/ap-3645-dont-switch-to-first-build-until-it-has-completed
branch
September 15, 2023 02:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to add a in progress indicator to this: https://linear.app/chromaui/issue/AP-3621#comment-1b9a109b, but in the meantime these stories just make sure the selected builds mirror what we want to happen.
@ghengeveld can you let me know if you want a separate ticket for the "first build" in progress UI linked above, or if you just plan to tackle it as part of what you are doing now.
To test:
📦 Published PR as canary version:
0.0.74--canary.89.65ca55a.0
✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.74--canary.89.65ca55a.0 # or yarn add @chromaui/addon-visual-tests@0.0.74--canary.89.65ca55a.0