Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Add icons in BrowserSelector list #96

Merged
merged 2 commits into from
Sep 14, 2023
Merged

UI: Add icons in BrowserSelector list #96

merged 2 commits into from
Sep 14, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Sep 12, 2023 •
edited by tmeasday
Loading

What I did:

📦 Published PR as canary version: 0.0.71--canary.96.715b834.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.71--canary.96.715b834.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.71--canary.96.715b834.0

@linear
Copy link

linear bot commented Sep 12, 2023

AP-3555 Show browser icons in the browser list

Current:

image.png

Expected:

Switch browser - Visual testing in Storybook (Figma)

@ndelangen ndelangen self-assigned this Sep 12, 2023
@ndelangen ndelangen added the enhancement Classification: Improvement to existing feature label Sep 12, 2023
@ndelangen ndelangen merged commit 17b6199 into main Sep 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghengeveld ghengeveld ghengeveld approved these changes

Assignees

@ndelangen ndelangen

Labels
enhancement Classification: Improvement to existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @ghengeveld