Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change destination of assets & css in Svelte Intro #433

Closed
wants to merge 1 commit into from
Closed

change destination of assets & css in Svelte Intro #433

wants to merge 1 commit into from

Conversation

rodgco
Copy link

@rodgco rodgco commented Jan 7, 2021

In Get Started for Svelte the existing CSS and assets (fonts & icons) where saved at ./src. It makes more sense to make those changes directly in ./public.

@jonniebigodes
Copy link
Collaborator

@rodgco thank you for the time and effort you put into the pull request, but sadly i'm going to close it. And go into a little bit of detail on why.

I'm well aware that you can put the assets directly into the public and you'll get access to them. But with a recent change introduced by CRA and React 17 some compromises had to be made for the css and assets (icons and fonts) to be properly displayed in the tutorial. Moving them into the src/assets folder allowed a more universal approach and get you and the rest of the community unblocked and able to go through the through the tutorial without adding more and more steps to the get started section, when the goal of that section is to get you onboarded with the minimum effort and move onto creating the components and stories. This approach serves a bit of a middle ground before #431 is set into motion. I'm currently researching this and trying to coordinate with the community to get a good starting point so that when you or any other reader comes into the tutorial he/she can go though the tutorial more smoothly. If you're able i would like to hear your thoughts in the issue i've linked.

Stay safe

@rodgco
Copy link
Author

rodgco commented Jan 7, 2021

@jonniebigodes the direction you're taking makes perfect sense. I'm new to SB and to Svelte, I'll try to contribute as much as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants