update french vuejs translation #434
Conversation
jeanphi-baconnais
changed the title
|
@jeanphibaconnais wow. I was checking and you updated this in a heartbeat. Really thankful for the the time you put into the pull request and how quickly you managed to get updated. A heads up for you and @Romainpetit i'm going to start updating the content based on #431 next week. So what this means is that @Romainpetit if you could leave the Get started section for last and for you @jeanphibaconnais i'll let you know once it's updated. I'll ping you when it's merged and we can start migrating the translations as well. Sounds good? Stay safe both of you |
Yes it's ok for me |
|
@jeanphibaconnais the pull request (#435) addresses the issue i've mentioned above. If you could adjust accordingly we could get this moving and get it updated and hopefully released soon. Sounds good? Stay safe |
|
Hi @jonniebigodes , i've just pushed modifications about your pull request #435 😄 |
|
@jeanphibaconnais with a recent change we've consolidated the documentation across Storybook and with that some changes were introduced. As you may have seen there's some conflicts in the pull request. When you get the chance could you please adjust accordingly? Hoping to see this updated and merged. Stay safe |
|
@jeanphibaconnais in light of the previous comment above, a recent pull request (#456 ) was introduced to fine tune the documentation. When you're able if you could pull in the changes and adjust accordingly we would really appreciate it. Let me know. Stay safe |
|
Hi @jonniebigodes i will try to work on this pull request this week ! I''m sorry, i changed work so february was a month with many things to finish 😁 |
|
@jeanphibaconnais no worries. Just let me know once you managed to get this across and we'll go from there. Wow, that seems like awesome news. Congrats on the new job 🎉. |
|
Thanks 🙂 i'll tell you this week I hope |
|
Hi @jonniebigodes i've just correct conflicts and take the PR 456 but actually there is a problem during build application. |
|
@winkerVSbecks could you coordinate with @jeanphibaconnais and see what might be the issue here? Thanks in advance. |
|
@jeanphibaconnais you need to run With the recent migration we now need to pull in some info from main storybook repo. I added instructions for this in the readme https://github.com/chromaui/learnstorybook.com#develop |
|
Hi, thanks @winkerVSbecks , it's now ok 👍 |
There was a problem hiding this comment.
@jeanphibaconnais some items related to this and we'll be good to go:
- If you could adjust the conclusion, more specifically the wording in this heading to something equivalent to "Who made the Intro to Storybook tutorial?"
- Also I saw that you committed your
yarn.lock, if you could remove it I would appreciate it as well.
Let me know once these are taken care of and I'll merge this.
Sounds good?
|
@jeanphibaconnais Feel free to ping me anytime if you need help translating the updated version or some proofreading ✌️ |
jeanphi-baconnais
force-pushed
the
update-french-vuejs-translation-
branch
2 times, most recently
from
4320024 to
22c935c
Compare
jeanphi-baconnais
changed the title
|
Hi, i start the french translation. I've just rebase and clean commit. I try to finish this one quickly. |
|
Hi @Dschungelabenteuer, i've just finish a first version of the translation. I try to keep some english words, like 'story', 'addon' (after introducing the french word). If you have some time to read those modifications, it would be welcome 😄 |
|
@jeanphibaconnais sorry for the "radio silence" but I've been busy with other items of documentation. I saw that the feedback is being addressed which is really awesome. Just one small item that needs to be addressed. If you could factor in #504 it would help us out greatly. Let me know once the change is introduced and we'll go from there. |
|
Hi @jonniebigodes , no problem :) |
jeanphi-baconnais
changed the title
|
Hi @jonniebigodes , have you see my comments on this PR ? |
fix : change snippet in english
jeanphi-baconnais
force-pushed
the
update-french-vuejs-translation-
branch
from
0eb3b20 to
9c71cad
Compare
|
Closing this pull request as mentioned in the issue @jeanphibaconnais! Looking forward to the updated translation. Have a great weekend! Stay safe |
No description provided.