Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation - design systems for developers | react #777

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

justine-tarlet
Copy link

@justine-tarlet justine-tarlet commented Sep 21, 2024

Description

Here is the pull request for the french translation of design systems for developers (react version) : https://storybook.js.org/tutorials/design-systems-for-developers/react/en/introduction/.
I hope I opened the PR the right way 😄 , this is my first contribution, tell me if there is any problem.

Notes for translation

Here is some main vocabulary and suggested translations:

  • design system / design systems : in french we usually keep this word in english
  • package: I also wouldn't translate it
  • project token: token de projet ?
  • commit: sometimes I see commiter but we can also say effectuer un commit
  • review: I see a lot of variants, I chose relecture and revue
  • addons: I used modules complémentaires and also simply addons
  • worklow: not so sure about this one, I translated it with flux de travail but we could also leave workflow

Hope this translation will help 🙏 feel free to ask questions and make some feedbacks.

Have a nice day!

Copy link

@jeanphi-baconnais jeanphi-baconnais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow great job @justine-tarlet 👏
I just quickly looked, I will continue this week

Copy link

@jeanphi-baconnais jeanphi-baconnais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @justine-tarlet 🙏

Copy link
Author

@justine-tarlet justine-tarlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jonniebigodes I hope you're doing well 😃 It looks like @jeanphi-baconnais and I have finished translating and proofreading this translation. I've launched and checked the project locally, everything seems to be working fine. I wanted to know if you had any feedback on the translations or any other updates we should add? I think I also read that the gastby.config file and the readme should be updated, but I'm not sure which version to specify? (7.6 juste like the English version?)
Thanks in advance for your help, and have a nice day! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants