Fix CJS entrypoint for manager code, and drop some unused things #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
added
patch
|
🚀 PR was released in |
JReinhold
requested changes
Sep 3, 2024
There was a problem hiding this comment.
I've dropped the files at the root because nothing is actually using these.
This is a common misconception, but it's actually wrong. You should revert that part @ghengeveld
See
storybookjs/addon-kit#66
|
Fixed in v4.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addon was broken because package.json is pointing to
./dist/manager.jsfor the managerrequireentrypoint, but this file did not exist. I've updated the TSUP config to generate this file. I've dropped the files at the root because nothing is actually using these.Update: Turns out those files are needed in some cases, so that part is reverted in v4.0.2.