+static-analysis config, ++(warning levels)

[ariccio]

Increased warning levels to 4, added a static analysis config.

[rpaquay]

Hmm, I get a bunch of C4100 errors when applying this patch (vs 2013):

1>------ Build started: Project: Native, Configuration: Release x64 ------
1>  stdafx.cpp
1>  dllmain.cpp
1>dllmain.cpp(10): warning C4100: 'lpReserved' : unreferenced formal parameter
1>dllmain.cpp(8): warning C4100: 'hModule' : unreferenced formal parameter
1>  search_base.cpp
1>d:\src\vsapps\vs-chromium\src\native\search_base.h(29): warning C4100: 'hr' : unreferenced formal parameter
1>d:\src\vsapps\vs-chromium\src\native\search_base.h(42): warning C4100: 'searchParams' : unreferenced formal parameter
1>search_base.cpp(66): warning C4127: conditional expression is constant
1>  search_boyer_moore.cpp
1>d:\src\vsapps\vs-chromium\src\native\search_base.h(29): warning C4100: 'hr' : unreferenced formal parameter
1>d:\src\vsapps\vs-chromium\src\native\search_base.h(42): warning C4100: 'searchParams' : unreferenced formal parameter

[ariccio]

For the dllmain.cpp lines 8 & 10, those are legit, and can be fixed by changing:

BOOL APIENTRY DllMain(HMODULE hModule,
                      DWORD  ul_reason_for_call,
                      LPVOID lpReserved) {

to:

BOOL APIENTRY DllMain(HMODULE /*hModule*/,
                      DWORD  ul_reason_for_call,
                      LPVOID /*lpReserved*/) {

...to indicate that they're not used.

For search_base.h, lines 29 & 42, those are also legit....what's going on there??

    void SetError(HRESULT hr, const char* message) {
      this->HResult = E_OUTOFMEMORY;
      strcpy_s(this->ErrorMessage, message);
    }

...what's the point of passing hr if you're not going to use it in any way?