Enable support for Visual Studio 2022 #79
Conversation
This approach follows the guidelines from https://github.com/microsoft/VSExtensibility/wiki. Notable changes: - Dropped support for Visual Studio 2015 *. - Now builds in Visual Studio 2019. - Upgraded to .NET Framework 4.7.2. - Upgraded to C++ toolset v142. - Moved all dependencies to PackageReference-style (maintaining the same version where possible). - Upgraded to newer style VSSDK (from NuGet packages). - Moved common files to a shared project and added "head" projects for pre-17 and 17-and-on versions of VSIX. - Added temporary code analysis suppression for some newly-enabled (with the SDK update) VSSDK and VSTHRD checkers. * Supporting Visual Studio 2015 *and* Visual Studio 2022 in one solution does not appear to be easy, so would incur higher maintenance cost. I propose that limiting the support to the three most recent major versions is acceptable. Minor changes: - EnumerableExtensions.ToHashSet is now superseded with the built-in support (.NET Framework 4.7.2 and newer). - Updated test mocks for Dialog with test-provided JoinableTaskContext. - Updated the test project to deploy the necessary binding redirects. All tests pass. Verified basic functionality (Search, Source Explorer) on: - Visual Studio 2017 (15.9.36) - Visual Studio 2019 (31409.95.d16.11) - Visual Studio 2022 (31409.368.d17.0)
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
@rpaquay You're the only contributor with any activity in the past year. Is this project effectively dead? I find the full text engine search to be just about the most important VS extension I have, and I would love to see it work with VS2022. |
|
@paulirish I hate to drag you into this thread, but your avatar was the first one I clicked on in the greater Chromium project. Can you answer my question above as to whether this project is effectively dead? It's a great extension just for the search capability alone. |
|
Hi there @moswald, The project is not dead, I just have not had time to look at this PR and I thought VS 2022 was not released yet, so I did not think this was urgent. Also, big thank you too @LukaszMendakiewicz for creating this PR. tldr: I will take a look at this shortly. |
Visual Studio 2022 is currently available in Preview: https://visualstudio.microsoft.com/vs/preview/vs2022/ |
|
@rpaquay Thanks! Again, sorry to be a bother! I'm keen to put the vs2022 preview through its paces and this extension is super useful to me. |
|
That would be great to merge :) |
|
I ran into a few issues with building this on VS 2019, which is why there is a delay. I will try to get back to it soon. |
|
Today VS22 has officially launched. Can't wait to install VS Chromium. Without it VS is just not complete. |
| @@ -10,19 +10,19 @@ | |||
| <RootNamespace>VsChromium.DkmIntegration</RootNamespace> | |||
| <AssemblyName>VsChromium.DkmIntegration</AssemblyName> | |||
| <FileAlignment>512</FileAlignment> | |||
| <TargetFrameworkVersion>v4.7.2</TargetFrameworkVersion> | |||
| <TargetFrameworkProfile /> | |||
| <NuGetPackageImportStamp> | |||
There was a problem hiding this comment.
This property is unneeded in PackageReference world.
|
I can't wait for this to get merged! |
|
Why is approving this PR postponed? |
|
I applied the PR to a side branch, and created a pre-release for it: https://github.com/chromium/vs-chromium/releases/tag/v0.9.38. I have not had time to do a lot of testing, but it seems to work on VS 2022 Final. Please open bugs if you see issues. The reason this has been delayed is that I am having issues running tests in VS2022, and I am still getting errors during build that I don't understand, even though these errors don't seem to prevent building a working VSIX file. |
|
Unfortunatley this VIX does not see VS2022.
|
|
Darn, wrong file. I created another release for vs2022 (https://github.com/chromium/vs-chromium/releases/tag/v0.9.39). |
|
Now it is working, but the names are swapped. VsChromium-0.9.39.vsix is for VS2022, VsChromium-Pre-VS2022-0.9.39.vsix is for VS2019. |
|
I'm getting #80 with the VS2022 release version one, and when I try to run the host process manually (by double-clicking) I get an array out of bounds exception:
Details |
That has been an issue with previous versions too and it shows after VS installer restarts it after an update. It's not a big deal and shouldn't be a blocker considering it's not a new issue. |
|
Thank you @petternilsen . I couldn't get it to resolve, but not it's suddenly working again. Sorry for the noise. |
|
Is there anything I can do to help get this PR accepted? |
|
No, I already merged it in a separate branch (https://github.com/chromium/vs-chromium/commits/pr79-add-vs2022-support) then made a couple of fixes related to package versions (see 213dba2) My plan it to merge that branch to master at some point. |
|
Hey, is there anything still preventing this from getting merged into master and making an official binary release? |
|
The pre-release build works. But any plans for merging this to the main branch? |
No, it does not work well in VS 2022. The settings for visualising code issues, that break the chromium code style, are not working. |
This approach follows the guidelines from https://github.com/microsoft/VSExtensibility/wiki.
Notable changes:
* Supporting Visual Studio 2015 and Visual Studio 2022 in one solution does not appear to be easy, so would incur higher maintenance cost. I propose that limiting the support to the three most recent major versions is acceptable.
Minor changes:
All tests pass.
Verified basic functionality (Search, Source Explorer) on: