Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Document Picture-in-Picture API (M111+) #3448

Closed
magreenblatt opened this issue Feb 8, 2023 · 5 comments
Closed

Add support for Document Picture-in-Picture API (M111+) #3448

magreenblatt opened this issue Feb 8, 2023 · 5 comments
Labels
enhancement Enhancement request Framework Related to framework code or APIs

Comments

@magreenblatt
Copy link
Collaborator

Original report by me.


Chrome is testing a new PiP mode that supports arbitrary HTML (blog post). This works in current Chrome Dev channel (111.0.5563.19) but not in CEF M111. Demo is https://document-picture-in-picture-api.glitch.me/

With Alloy runtime, this fails with ReferenceError: documentPictureInPicture is not defined.

With Chome runtime, this creates a fully styled popup window (vs expected window with minimal frame).

With Chrome Dev channel (expected result):


@magreenblatt
Copy link
Collaborator Author

chrome: Use default Browser creation for picture-in-picture popups (see issue #3448)

→ <<cset 82dc13a87001 (bb)>>

@magreenblatt
Copy link
Collaborator Author

This now works as expected with the Chrome runtime in 5563 release branch but not current master (based on M111), due to additional Chromium fixes that have been cherry-picked to the release branch.

@magreenblatt
Copy link
Collaborator Author

chrome: Use default Browser creation for picture-in-picture popups (see issue #3448)

Note: In current master (based on M111), document PiP partially works when
run with the --enable-features=DocumentPictureInPictureAPI command-line
flag. However, the document PiP implementation at this Chromium version is
missing fixes that have already been cherry-picked to the 5563 release
branch. Those fixes will only be available in master after the next Chromium
update (to M112).

→ <<cset ff68c0154323 (bb)>>

@magreenblatt
Copy link
Collaborator Author

The Chrome runtime is now supported. The Alloy runtime will not be supported at this time.

@magreenblatt
Copy link
Collaborator Author

  • changed state from "new" to "resolved"

khangthk pushed a commit to khangthk/cef that referenced this issue Apr 2, 2023
…ee issue chromiumembedded#3448)

Note: In current master (based on M111), document PiP partially works when
run with the `--enable-features=DocumentPictureInPictureAPI` command-line
flag. However, the document PiP implementation at this Chromium version is
missing fixes that have already been cherry-picked to the 5563 release
branch. Those fixes will only be available in master after the next Chromium
update (to M112).
magreenblatt added a commit that referenced this issue Sep 20, 2023
This feature is default-enabled in M116+ but is not supported by the
Alloy runtime.
magreenblatt added a commit that referenced this issue Sep 20, 2023
This feature is default-enabled in M116+ but is not supported by the
Alloy runtime.
magreenblatt added a commit that referenced this issue Sep 20, 2023
This feature is default-enabled in M116+ but is not supported by the
Alloy runtime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement request Framework Related to framework code or APIs
Projects
None yet
Development

No branches or pull requests

1 participant