-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crashes when opening a downloaded pdf #3750
Comments
Looks like another example of #3720.
|
I'm seeing a different crash in M128 (Windows 11), failing the DCHECK here.
This is a new Browser (no WebContents yet) created using ScopedTabbedBrowserDisplayer in ChromeDownloadManagerDelegate::OpenDownload. The intention of ScopedTabbedBrowserDisplayer is to create a new Browser (with TabStrip) if one does not already exist for the current Profile. CEF-hosted Browsers do not have a TabStrip and consequently don't match this logic. In the CEF case we should probably route these calls to OnOpenURLFromTab for the source Browser, as would happen in the normal "open in new tab" flow. |
Some downloaded file types [1] default to opening in a Browser. Open requests for these file types originating from the Download bubble UI should route to the source Browser (call OnOpenURLFromTab). If OnOpenURLFromTab is unhandled proceed with the default Chrome behavior of opening the URL in a new default Browser. [1] PDF, html, etc. For the complete list of file types see ChromeDownloadManagerDelegate::IsOpenInBrowserPreferredForFile.
The dangling rawptr crash mentioned above appears to be fixed in M128. |
Some downloaded file types [1] default to opening in a Browser. Open requests for these file types originating from the Download bubble UI should route to the source Browser (call OnOpenURLFromTab). If OnOpenURLFromTab is unhandled proceed with the default Chrome behavior of opening the URL in a new default Browser. [1] PDF, html, etc. For the complete list of file types see ChromeDownloadManagerDelegate::IsOpenInBrowserPreferredForFile.
Describe the bug
Downloading then opening a pdf file makes CEF crash. We get the following entry in debug.log:
[0719/154357.911:ERROR:crashpad_client_win.cc(868)] not connected
To Reproduce
Steps to reproduce the behavior with either cefclient or cefsimple:
Expected behavior
Expected behavior is to open the file in the pdf reader
Versions (please complete the following information):
Additional context
The problem occurs with both cefclient and cefsimple, in debug and release.
The text was updated successfully, but these errors were encountered: