Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format day in RFC 2822 without padding #1272

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

pitdicker
Copy link
Collaborator

DateTime::to_rfc2822 would format the day value with space padding when #249 was opened. #844 changed it to zero padding, probably unintentionally. No padding at all seems more in line with the standard.

We had no test for this case.

Fixes #1269.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #1272 (8acac3b) into 0.4.x (77d0bec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            0.4.x    #1272   +/-   ##
=======================================
  Coverage   91.40%   91.41%           
=======================================
  Files          38       38           
  Lines       16932    16939    +7     
=======================================
+ Hits        15477    15484    +7     
  Misses       1455     1455           
Files Changed Coverage Δ
src/datetime/tests.rs 96.43% <100.00%> (+0.01%) ⬆️
src/format/formatting.rs 94.75% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@pitdicker pitdicker merged commit 084b021 into chronotope:0.4.x Sep 11, 2023
37 checks passed
@pitdicker pitdicker deleted the rfc2822_formatting_tweak branch September 11, 2023 08:34
andy128k added a commit to rust-syndication/rss that referenced this pull request Jan 13, 2024
Chrono changed day formatting in 0.4.31 chronotope/chrono#1272
andy128k added a commit to rust-syndication/rss that referenced this pull request Jan 13, 2024
Chrono changed day formatting in 0.4.31 chronotope/chrono#1272
andy128k added a commit to rust-syndication/rss that referenced this pull request Jan 13, 2024
Chrono changed day formatting in 0.4.31 chronotope/chrono#1272
andy128k added a commit to rust-syndication/rss that referenced this pull request Jan 13, 2024
Chrono changed day formatting in 0.4.31 chronotope/chrono#1272
andy128k added a commit to rust-syndication/rss that referenced this pull request Jan 13, 2024
Chrono changed day formatting in 0.4.31 chronotope/chrono#1272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants