Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NaiveTime::overflowing_(add|sub)_offset #1310

Merged
merged 3 commits into from
Sep 23, 2023

Conversation

pitdicker
Copy link
Collaborator

On its own these methods are not that useful. We need them to nicely implement NaiveDateTime::checked_(add|sub)_offset.
It does make the existing Add and Sub implementations simpler.

Split out from #1069.

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #1310 (655a1a4) into 0.4.x (41e34ad) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            0.4.x    #1310      +/-   ##
==========================================
+ Coverage   91.00%   91.04%   +0.03%     
==========================================
  Files          38       38              
  Lines       17068    17100      +32     
==========================================
+ Hits        15533    15568      +35     
+ Misses       1535     1532       -3     
Files Changed Coverage Δ
src/offset/fixed.rs 80.71% <ø> (+1.26%) ⬆️
src/naive/time/mod.rs 95.92% <100.00%> (+0.08%) ⬆️
src/naive/time/tests.rs 98.44% <100.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pitdicker
Copy link
Collaborator Author

🎉

@pitdicker pitdicker merged commit a47e0e3 into chronotope:0.4.x Sep 23, 2023
37 checks passed
@pitdicker pitdicker deleted the overflowing_add_offset branch September 23, 2023 12:33
@pitdicker pitdicker mentioned this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants