Fix Duration::MIN.abs() (adjust Duration::MIN by 1 millisecond)
#1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitdicker
force-pushed
the
duration_abs_min
branch
from
0d832a1
to
70052e0
Compare
Codecov Report
@@ Coverage Diff @@
## 0.4.x #1334 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 38 38
Lines 17352 17355 +3
=======================================
+ Hits 15886 15889 +3
Misses 1466 1466
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Sep 29, 2023
|
Wow, approved before the CI is even ready! |
This was referenced Jan 24, 2024
danwilliams
added a commit
to danwilliams/rubedo
that referenced
this pull request
Jan 28, 2024
- Adjusted MIN_MILLISECONDS, MIN_NANOSECONDS_FULL, and
MIN_MICROSECONDS_FULL due to changes in Chrono 0.4.32 that were not
previously noticed, which restrict the minimum value of milliseconds
by 1, by changing the limit from i64::MIN to -i64::MAX. This was
carried out under chronotope/chrono#1334.
Notably, Chrono 0.4.32 does still allow creation of a Duration with
a milliseconds value of i64::MIN, which is why this change was not
noticed sooner. This will be corrected when Chrono 0.4.34 is
released, with chronotope/chrono#1385. In
the meantime, the correction of constant values here means that we
are now compatible with both versions and also do not suffer from
the current Chrono bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Duration::MIN.abs()will create a value that is 1 millisecond beyondDuration::MAX.abs().We can choose to add a fallible variant of
Duration::abs.But given that
Duration::MINis pretty much chosen arbitrarily asi64::MINmilliseconds, I propose to redefine it as-i64::MAXmilliseconds and make the range symmetrical.