Make methods on DateTime
const where possible
#1400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rust 1.61 it is possible to make these methods const.
In theory we should be careful with making methods on
DateTime
const. If we discover a method need to change and use something from theTimeZone
trait it can no longer be const, which would be a breaking change.But all the methods that can be made const in this PR clearly operate on UTC values, or return just a field of the
DateTime
type.This completes the work to make the API const were possible 🎉.