Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TOO_LONG error out of parse_internal #1419

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

pitdicker
Copy link
Collaborator

parse_internal returns the TOO_LONG error if there is input remaining. With one exception the callers than inspect the error and continue in that case.

Moving the check to parse is a nice little simplification.
As a side effect this fixes the wrong NOT_ENOUGH error in parse_rfc3339_relaxed, which should be TOO_SHORT.

cc @Zomtir (I'm just including you on all the error work)

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pitdicker pitdicker merged commit ded9fe1 into chronotope:main Feb 9, 2024
30 of 35 checks passed
@pitdicker pitdicker deleted the too_long branch February 9, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants