Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #1027.
We have now had three issues on how to create a
DateTime
for today at a specific time: #1022, #1447 and #1508.We could add a
today_at
method toLocal
(and may still want to do so), butDateTime::with_time()
is a more generic solution.A second reason to want this method is it gives a way to deal with the one remaining panic case from #1047 that I don't have a workaround for: If users write
dt.timezone().from_local_datetime(&dt.date().and_time(time))
it may panic when theNaiveDateTime
in UTC is at the edge of the representable range, and the localNaiveDate
is out of range. We can internally useoverflowing_naive_local()
and return a result if that is in range.Renamed from
set_time
towith_time
to match the otherwith_*
methods.