Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add #[inline] to num_days #1627

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

CommanderStorm
Copy link
Contributor

@CommanderStorm CommanderStorm commented Nov 9, 2024

While looking at the code, I noticed something.
All num_* funktions (which do the same thing, but for other divisors) are marked #[inline], except for num_days.

=> it looks not marking this method as #[inline] is a mistake.

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (7974c60) to head (2f8e09e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1627   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files          37       37           
  Lines       17137    17137           
=======================================
  Hits        15616    15616           
  Misses       1521     1521           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

The wasm test failure is unrelated, so ignoring that.

@djc djc merged commit f9ffd6f into chronotope:main Nov 11, 2024
34 of 35 checks passed
@CommanderStorm CommanderStorm deleted the patch-1 branch November 11, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants