Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Carthage support by sharing Pod schemes #49

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

chrs1885
Copy link
Owner

@chrs1885 chrs1885 commented Jan 3, 2020

Issue information

Alternative to #48 #47 by sharing schemes of the Pods-project.

Goal

Adding Carthage support without explicitly re-adding the Capable project file.

Implementation

Sharing the shemes.

Testing

@chrs1885 chrs1885 changed the title Feature/48 carthage support Add Carthage support by sharing Pod schemes Jan 3, 2020
@jefflen
Copy link

jefflen commented Jan 9, 2020

@chrs1885 First of all sorry for the late reply. Happy New Year!

Thanks for suggesting the alternative solution, however I have tried to install by using Carthage, it wouldn't compile due to this error:

/usr/bin/xcrun xcodebuild -workspace /Users/hlu/git_tree/pulse-ios/Carthage/Checkouts/Capable/Example/Example.xcworkspace -scheme Capable-iOS -configuration Release -derivedDataPath /Users/hlu/Library/Caches/org.carthage.CarthageKit/DerivedData/11.2_11B52/Capable/1a932fba4037527b140be9aa605cd5e0ebbd5f31 -sdk iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/27/t2yd_x8n0fdb9ggvg4nh6tmw8z8bsn/T/Capable SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in /Users/hlu/git_tree/pulse-ios/Carthage/Checkouts/Capable)User defaults from command line:
    IDEArchivePathOverride = /var/folders/27/t2yd_x8n0fdb9ggvg4nh6tmw8z8bsn/T/Capable
    IDEDerivedDataPathOverride = /Users/hlu/Library/Caches/org.carthage.CarthageKit/DerivedData/11.2_11B52/Capable/1a932fba4037527b140be9aa605cd5e0ebbd5f31

Build settings from command line:
    CARTHAGE = YES
    CLANG_ENABLE_CODE_COVERAGE = NO
    CODE_SIGN_IDENTITY = 
    CODE_SIGNING_REQUIRED = NO
    GCC_INSTRUMENT_PROGRAM_FLOW_ARCS = NO
    ONLY_ACTIVE_ARCH = NO
    SDKROOT = iphoneos13.2
    SKIP_INSTALL = YES
    STRIP_INSTALLED_PRODUCT = NO

note: Using new build system
note: Planning build
note: Constructing build description
error: /Users/hlu/git_tree/pulse-ios/Carthage/Checkouts/Capable/Example/Pods/Target Support Files/Capable-iOS/Capable-iOS.xcconfig: unable to open file (in target "Capable-iOS" in project "Pods") (in target 'Capable-iOS' from project 'Pods')
error: /Users/hlu/git_tree/pulse-ios/Carthage/Checkouts/Capable/Example/Pods/Target Support Files/Capable-iOS/Capable-iOS.xcconfig: unable to open file (in target "Capable-iOS" in project "Pods") (in target 'Capable-iOS' from project 'Pods')
error: /Users/hlu/git_tree/pulse-ios/Carthage/Checkouts/Capable/Example/Pods/Target Support Files/Capable-iOS/Capable-iOS.xcconfig: unable to open file (in target "Capable-iOS" in project "Pods") (in target 'Capable-iOS' from project 'Pods')
error: missing module map file: '/Users/hlu/git_tree/pulse-ios/Carthage/Checkouts/Capable/Example/Pods/Target Support Files/Capable-iOS/Capable-iOS.modulemap (in target 'Capable-iOS' from project 'Pods')

** ARCHIVE FAILED **

I think the problem is the installed Pods folder wasn't pushed, hence it couldn't be compiled. One solution is to push the installed Pods to the repo. But I'm not sure if it makes sense.

I have also made some changes in #48 to be included Capable.xcodeproj in the Example.xcworkspace plus the shared schemes, could you help to have a look and see if it makes more sense?

@chrs1885
Copy link
Owner Author

chrs1885 commented Jan 19, 2020

Hi @jefflen. Happy new year to you, too. And thanks for being so patient =)
I do prefer pushing the example app's Pods dir over re-adding the project file. Can you give it another shot?
Simply add github "chrs1885/Capable" "feature/48-carthage-support"to your Cartfile.

@chrs1885 chrs1885 force-pushed the feature/48-carthage-support branch 7 times, most recently from e12fddf to bada013 Compare January 19, 2020 16:20
@jefflen
Copy link

jefflen commented Feb 5, 2020

Hi @chrs1885, sorry for the delay of response as I just came back from a one month long vacation.

I have tried adding it in Carthage with the branch feature/48-carthage-support and it works perfectly fine! I will close my PR now.

I am looking forward this to be released soon and I can skip to add the branch name in my Cartfile.

Thanks a lot for your support.

@chrs1885 chrs1885 merged commit dd7af9e into develop Feb 5, 2020
@chrs1885
Copy link
Owner Author

chrs1885 commented Feb 5, 2020

@jefflen Thank you so much for your support during the last couple of weeks. Finally, Carthage support has been fixed in https://github.com/chrs1885/Capable/tree/1.1.2 🍺

@chrs1885 chrs1885 deleted the feature/48-carthage-support branch February 11, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants