Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming collisions with SwiftUI #51

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

chrs1885
Copy link
Owner

Issue information

Capable is using typealias names (e.g. NSColor, UIColor) inside extensions to avoid code duplication. When using the framework along with SwiftUI, building fails due to naming collisions (SwiftUI Color and typealias Color for NSColor, UIColor).

Goal

Avoid naming collisions 😁

Implementation

Rename typealias names

Testing

Run Unit Tests

Implementation

📝

Testing

📝

@chrs1885 chrs1885 merged commit ae1f210 into develop Feb 11, 2020
@chrs1885 chrs1885 deleted the feature/fix-swiftui-naming-collision branch February 11, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants