Skip to content

Commit

Permalink
Fix condition for is_internal (go-gitea#22095) (go-gitea#22131)
Browse files Browse the repository at this point in the history
Backport of go-gitea#22095

I changed it to a static condition because it needs a new version of
xorm which is only available in 1.19. This change is valid because
`SearchLatestVersions` is never called to list internal versions and
there will no change to this behaviour in <1.19.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
  • Loading branch information
3 people authored Dec 14, 2022
1 parent 0e95e74 commit 6f323d1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion models/packages/package_version.go
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ func SearchLatestVersions(ctx context.Context, opts *PackageSearchOptions) ([]*P

sess := db.GetEngine(ctx).
Table("package_version").
Join("LEFT", "package_version pv2", "package_version.package_id = pv2.package_id AND (package_version.created_unix < pv2.created_unix OR (package_version.created_unix = pv2.created_unix AND package_version.id < pv2.id))").
Join("LEFT", "package_version pv2", "package_version.package_id = pv2.package_id AND pv2.is_internal = ? AND (package_version.created_unix < pv2.created_unix OR (package_version.created_unix = pv2.created_unix AND package_version.id < pv2.id))", false).
Join("INNER", "package", "package.id = package_version.package_id").
Where(cond)

Expand Down

0 comments on commit 6f323d1

Please sign in to comment.